evol3D/evol-headers
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed ev_vec_pop not always free'ing the popped element
Run tests / Run tests (push) Failing after 9s
Details

Browse Source
This commit is contained in:
Robear Selwans
2026-05-03 23:23:47 +03:00
parent 8b6c7ec42a
commit e7c6cc507c
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ev_vec.h
+7 -8
View File
@@ -643,20 +643,19 @@ ev_vec_pop(
if(metadata->length == 0) return EV_VEC_ERR_INVALID_OP; if(metadata->length == 0) return EV_VEC_ERR_INVALID_OP;
void *elem = ((char *)*v) + ((metadata->length-1) * metadata->typeData.size);
if(out != NULL) { if(out != NULL) {
void *src = ((char *)*v) + ((metadata->length-1) * metadata->typeData.size);
if (metadata->typeData.copy_fn) { if (metadata->typeData.copy_fn) {
metadata->typeData.copy_fn(out, src); metadata->typeData.copy_fn(out, elem);
} else { } else {
memcpy(out, src, metadata->typeData.size); memcpy(out, elem, metadata->typeData.size);
}
} else {
void *elem = ((char *)*v) + ((metadata->length-1) * metadata->typeData.size);
if (metadata->typeData.free_fn) {
metadata->typeData.free_fn(elem);
} }
} }
if (metadata->typeData.free_fn) {
metadata->typeData.free_fn(elem);
}
metadata->length--; metadata->length--;
return EV_VEC_ERR_NONE; return EV_VEC_ERR_NONE;